PEP Withdrawal

Withdrawn in favor of PEP 567.

Abstract

While we generally try to avoid global state when possible, there nonetheless exist a number of situations where it is agreed to be the best approach. In Python, a standard pattern for handling such cases is to store the global state in global or thread-local storage, and then use with blocks to limit modifications of this global state to a single dynamic scope. Examples where this pattern is used include the standard library’s warnings.catch_warnings and decimal.localcontext, NumPy’s numpy.errstate (which exposes the error-handling settings provided by the IEEE 754 floating point standard), and the handling of logging context or HTTP request context in many server application frameworks.

However, there is currently no ergonomic way to manage such local changes to global state when writing a generator or coroutine. For example, this code:

def f():
    with warnings.catch_warnings():
        for x in g():
            yield x

may or may not successfully catch warnings raised by g(), and may or may not inadvertently swallow warnings triggered elsewhere in the code. The context manager, which was intended to apply only to f and its callees, ends up having a dynamic scope that encompasses arbitrary and unpredictable parts of its callers. This problem becomes particularly acute when writing asynchronous code, where essentially all functions become coroutines.

Here, we propose to solve this problem by notifying context managers whenever execution is suspended or resumed within their scope, allowing them to restrict their effects appropriately.

Specification

Two new, optional, methods are added to the context manager protocol: __suspend__ and __resume__. If present, these methods will be called whenever a frame’s execution is suspended or resumed from within the context of the with block.

More formally, consider the following code:

with EXPR as VAR:
    PARTIAL-BLOCK-1
    f((yield foo))
    PARTIAL-BLOCK-2

Currently this is equivalent to the following code (copied from PEP 343):

mgr = (EXPR)
exit = type(mgr).__exit__  # Not calling it yet
value = type(mgr).__enter__(mgr)
exc = True
try:
    try:
        VAR = value  # Only if "as VAR" is present
        PARTIAL-BLOCK-1
        f((yield foo))
        PARTIAL-BLOCK-2
    except:
        exc = False
        if not exit(mgr, *sys.exc_info()):
            raise
finally:
    if exc:
        exit(mgr, None, None, None)

This PEP proposes to modify with block handling to instead become:

mgr = (EXPR)
exit = type(mgr).__exit__  # Not calling it yet
### --- NEW STUFF ---
if the_block_contains_yield_points:  # known statically at compile time
    suspend = getattr(type(mgr), "__suspend__", lambda: None)
    resume = getattr(type(mgr), "__resume__", lambda: None)
### --- END OF NEW STUFF ---
value = type(mgr).__enter__(mgr)
exc = True
try:
    try:
        VAR = value  # Only if "as VAR" is present
        PARTIAL-BLOCK-1
        ### --- NEW STUFF ---
        suspend(mgr)
        tmp = yield foo
        resume(mgr)
        f(tmp)
        ### --- END OF NEW STUFF ---
        PARTIAL-BLOCK-2
    except:
        exc = False
        if not exit(mgr, *sys.exc_info()):
            raise
finally:
    if exc:
        exit(mgr, None, None, None)

Analogous suspend/resume calls are also wrapped around the yield points embedded inside the yield from, await, async with, and async for constructs.

def f():
    with OUTER:
        with INNER:
            yield VALUE

INNER.__suspend__()
OUTER.__suspend__()
yield VALUE
OUTER.__resume__()
INNER.__resume__()

def f():
    with OUTER:
        yield from g()

def g():
    with INNER
        yield VALUE

Rationale

In the abstract, we gave an example of plausible but incorrect code:

def f():
    with warnings.catch_warnings():
        for x in g():
            yield x

To make this correct in current Python, we need to instead write something like:

def f():
    with warnings.catch_warnings():
        it = iter(g())
    while True:
        with warnings.catch_warnings():
            try:
                x = next(it)
            except StopIteration:
                break
        yield x

OTOH, if this PEP is accepted then the original code will become correct as-is. Or if this isn’t convincing, then here’s another example of broken code; fixing it requires even greater gyrations, and these are left as an exercise for the reader:

async def test_foo_emits_warning():
    with warnings.catch_warnings(record=True) as w:
        await foo()
    assert len(w) == 1
    assert "xyzzy" in w[0].message

And notice that this last example isn’t artificial at all – this is exactly how you write a test that an async/await-using coroutine correctly raises a warning. Similar issues arise for pretty much any use of warnings.catch_warnings, decimal.localcontext, or numpy.errstate in async/await-using code. So there’s clearly a real problem to solve here, and the growing prominence of async code makes it increasingly urgent.

with warnings.catch_warnings():
    loop.call_soon(f)

Backwards compatibility

Because __suspend__ and __resume__ are optional and default to no-ops, all existing context managers continue to work exactly as before.

Speed-wise, this proposal adds additional overhead when entering a with block (where we must now check for the additional methods; failed attribute lookup in CPython is rather slow, since it involves allocating an AttributeError), and additional overhead at suspension points. Since the position of with blocks and suspension points is known statically, the compiler can straightforwardly optimize away this overhead in all cases except where one actually has a yield inside a with. Furthermore, because we only do attribute checks for __suspend__ and __resume__ once at the start of a with block, when these attributes are undefined then the per-yield overhead can be optimized down to a single C-level if (frame->needs_suspend_resume_calls) { ... }. Therefore, we expect the overall overhead to be negligible.

Interaction with PEP 492

PEP 492 added new asynchronous context managers, which are like regular context managers, but instead of having regular methods __enter__ and __exit__ they have coroutine methods __aenter__ and __aexit__.

Following this pattern, one might expect this proposal to add __asuspend__ and __aresume__ coroutine methods. But this doesn’t make much sense, since the whole point is that __suspend__ should be called before yielding our thread of execution and allowing other code to run. The only thing we accomplish by making __asuspend__ a coroutine is to make it possible for __asuspend__ itself to yield. So either we need to recursively call __asuspend__ from inside __asuspend__, or else we need to give up and allow these yields to happen without calling the suspend callback; either way it defeats the whole point.

Well, with one exception: one possible pattern for coroutine code is to call yield in order to communicate with the coroutine runner, but without actually suspending their execution (i.e., the coroutine might know that the coroutine runner will resume them immediately after processing the yielded message). An example of this is the curio.timeout_after async context manager, which yields a special set_timeout message to the curio kernel, and then the kernel immediately (synchronously) resumes the coroutine which sent the message. And from the user point of view, this timeout value acts just like the kinds of global variables that motivated this PEP. But, there is a crucal difference: this kind of async context manager is, by definition, tightly integrated with the coroutine runner. So, the coroutine runner can take over responsibility for keeping track of which timeouts apply to which coroutines without any need for this PEP at all (and this is indeed how curio.timeout_after works).

That leaves two reasonable approaches to handling async context managers:

1. Add plain __suspend__ and __resume__ methods.
2. Leave async context managers alone for now until we have more experience with them.

Either seems plausible, so out of laziness / YAGNI this PEP tentatively proposes to stick with option (2).

References

Copyright

This document has been placed in the public domain.